Issue 5888043: code review 5888043: cmd/godoc: fix error on IE8.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5888043: code review 5888043: cmd/godoc: fix error on IE8. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 1 month ago by mattn

Modified:
13 years ago

Reviewers:

CC:
golang-dev_googlecode.com, rsc, adg, golang-dev

Visibility:
Public.

Description

misc/goplay: fix error on IE8. use cancelBubble=true instead of preventDefault().

Patch Set 1 #

Patch Set 2 : diff -r 7e4c7879d395 http://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 7e4c7879d395 http://go.googlecode.com/hg/ #

Created: 13 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -2 lines)			Patch
	M	misc/goplay/goplay.go	View	1	1 chunk	+10 lines, -2 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

mattn

Hello golang-dev@googlecode.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to http://go.googlecode.com/hg/

13 years, 1 month ago (2012-03-23 01:19:23 UTC) #1

rsc

Please change the title of the CL from "cmd/godoc" to "misc/goplay". Thanks.

13 years, 1 month ago (2012-03-26 13:17:10 UTC) #2

mattn

On 2012/03/26 13:17:10, rsc wrote: > Please change the title of the CL from "cmd/godoc" ...

13 years, 1 month ago (2012-03-27 00:12:27 UTC) #3

adg

13 years, 1 month ago (2012-03-27 00:16:35 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=d149fef3f3c2 ***

misc/goplay: fix error on IE8.
        use cancelBubble=true instead of preventDefault().

R=golang-dev, rsc, adg
CC=golang-dev
http://codereview.appspot.com/5888043

Committer: Andrew Gerrand <adg@golang.org>

Expand All Messages | Collapse All Messages