Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(11273)

Issue 5882058: [ASan/tests] Make 'noinline' and a bunch of other stuff portable (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by timurrrr_at_google_com
Modified:
12 years, 1 month ago
Reviewers:
glider
CC:
llvm-commits_cs.uiuc.edu
Base URL:
https://llvm.org/svn/llvm-project/compiler-rt/trunk/lib/asan/
Visibility:
Public.

Description

Committed http://llvm.org/viewvc/llvm-project?view=rev&revision=153333

Patch Set 1 #

Patch Set 2 : merged some lines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -52 lines) Patch
M tests/asan_test.cc View 1 15 chunks +33 lines, -51 lines 0 comments Download
M tests/asan_test_utils.h View 1 chunk +27 lines, -1 line 0 comments Download

Messages

Total messages: 5
timurrrr_at_google_com
Hi Alexander, Can you please review this simple patch? FYI, the #ifdef'ed parts were copied ...
12 years, 1 month ago (2012-03-23 12:33:21 UTC) #1
glider
LGTM
12 years, 1 month ago (2012-03-23 12:50:41 UTC) #2
timurrrr_at_google_com
Can you PTAL? I've merged some short strings together
12 years, 1 month ago (2012-03-23 13:10:06 UTC) #3
glider
LGTM
12 years, 1 month ago (2012-03-23 13:11:45 UTC) #4
timurrrr_at_google_com
12 years, 1 month ago (2012-03-23 13:16:13 UTC) #5
r153333, thanks!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b