Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(72)

Issue 5864053: code review 5864053: go/build: clarify why we exclude files starting with '_... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 1 month ago by minux1
Modified:
13 years, 1 month ago
Reviewers:
CC:
golang-dev, gri
Visibility:
Public.

Description

go/build: clarify why we exclude files starting with '_' or '.'

Patch Set 1 #

Patch Set 2 : diff -r 74edd315eec5 https://code.google.com/p/go/ #

Total comments: 1

Patch Set 3 : diff -r f180ac52630b https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/pkg/go/build/build.go View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
minux1
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
13 years, 1 month ago (2012-03-21 19:05:06 UTC) #1
minux1
It took me quite some time digging into the hg history to find out this ...
13 years, 1 month ago (2012-03-21 19:08:48 UTC) #2
gri
LGTM please shorten the comment a bit per suggestion http://codereview.appspot.com/5864053/diff/2001/src/pkg/go/build/build.go File src/pkg/go/build/build.go (right): http://codereview.appspot.com/5864053/diff/2001/src/pkg/go/build/build.go#newcode340 src/pkg/go/build/build.go:340: ...
13 years, 1 month ago (2012-03-21 19:12:12 UTC) #3
minux1
13 years, 1 month ago (2012-03-21 19:18:59 UTC) #4
*** Submitted as http://code.google.com/p/go/source/detail?r=49243ebbbda6 ***

go/build: clarify why we exclude files starting with '_' or '.'

R=golang-dev, gri
CC=golang-dev
http://codereview.appspot.com/5864053
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b