Issue 5848067: code review 5848067: sort: fix computation of maxDepth to avoid infinite loop

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5848067: code review 5848067: sort: fix computation of maxDepth to avoid infinite loop (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 1 month ago by Stefan Nilsson

Modified:
13 years, 1 month ago

Reviewers:

CC:
golang-dev, gri

Visibility:
Public.

Description

sort: fix computation of maxDepth to avoid infinite loop The current computation loops indefinitely if n > 1<<30 (for 32-bit ints).

Patch Set 1 #

Patch Set 2 : diff -r fbc982f5aff1 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r fbc982f5aff1 https://go.googlecode.com/hg/ #

Created: 13 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	src/pkg/sort/sort.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Stefan Nilsson

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 1 month ago (2012-03-20 09:59:55 UTC) #1

gri

13 years, 1 month ago (2012-03-20 21:23:14 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=87d50a70f7d2 ***

sort: fix computation of maxDepth to avoid infinite loop

The current computation loops indefinitely if n > 1<<30 (for 32-bit ints).

R=golang-dev, gri
CC=golang-dev
http://codereview.appspot.com/5848067

Committer: Robert Griesemer <gri@golang.org>

Expand All Messages | Collapse All Messages