code review 5848066: run.bat: disable test in test\bench\go1 to fix build

run.bat: disable test in test\bench\go1 to fix build

[brainman, 2012-03-20 03:48:22]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[r, 2012-03-20 03:57:32]

LGTM
Really?

[brainman, 2012-03-20 03:59:58]

*** Submitted as http://code.google.com/p/go/source/detail?r=fbc982f5aff1 ***

run.bat: disable test in test\bench\go1 to fix build

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/5848066

[brainman, 2012-03-20 04:02:22]

On 2012/03/20 03:57:32, r wrote:
> Really?

I hope my temp fix will work.

I never had to deal with paths that long. I am pretty sure, it can be overcome.
I just need to understand what to do :-). Which syscall functions needs to be
adjusted and how.

Alex

[aram, 2012-03-20 13:13:58]

>
> I never had to deal with paths that long. I am pretty sure, it can be
> overcome. I just need to understand what to do :-). Which syscall
> functions needs to be adjusted and how.
>

It's pretty easy, I see that the Windows port uses the Unicode variants
of functions, like CreateFileW, in this case you only need to
prepend the paths with \\?\, for more information see
this very long and sterile article:

    http://msdn.microsoft.com/en-us/library/Aa365247

[aram, 2012-03-23 11:13:58]

To answer your comments on issue 3358:
>
>
Making the normalization ourselves is a mistake because we can't mimic the 
side effects
of a relative path hitting the I/O manager and because we'd have to ignore 
that the Win32
namespace is private to a session.

If you used the real syscall wrapper (ZwCreateFile) instead of the Win32 
CreateFile,
you could use the path as is and not have the the mentioned normalization 
issues,
nor the path length problem. You'd have the problem of initializing the 
RootDirectory handle
in the OBJECT_ATTRIBUTES structure, but that's easier than making the 
normalization
ourselves.

I'm not advocating for the latter either. I think that the current behavior 
is the correct
thing to do.