code review 5847061: misc/cgo/gmp: update for Go 1

misc/cgo/gmp: update for Go 1
1. make the program go buildable
2. update os.EINVAL and runtime.Cgocalls()
3. wrap mpz_div_2exp() and mpz_mul_2exp to support both
   pre-5.0 and post-5.0 gmp (we really have no reason to
   restrict ourselves to gmp 5.0+)

[minux1, 2012-03-18 18:13:20]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[remyoudompheng, 2012-03-18 18:21:16]

http://codereview.appspot.com/5847061/diff/4001/misc/cgo/gmp/gmp.go
File misc/cgo/gmp/gmp.go (right):

http://codereview.appspot.com/5847061/diff/4001/misc/cgo/gmp/gmp.go#newcode197
misc/cgo/gmp/gmp.go:197: return syscall.EINVAL
why not os.ErrInvalid ?

[minux1, 2012-03-18 19:02:08]

PTAL.
On 2012/03/18 18:21:16, remyoudompheng wrote:
http://codereview.appspot.com/5847061/diff/4001/misc/cgo/gmp/gmp.go#newcode197
> misc/cgo/gmp/gmp.go:197: return syscall.EINVAL
> why not os.ErrInvalid ?
Oh, I forget this one. Fixed.

[iant, 2012-03-19 22:06:37]

LGTM

I think this is OK to commit now because these files are not touched in a normal
build, so this is essentially documentation for Go 1.  I don't think we should
add this directory to src/run.bash yet, but we should do so after the Go 1
release.

[minux1, 2012-03-20 16:51:57]

*** Submitted as http://code.google.com/p/go/source/detail?r=05fd7717dfc0 ***

misc/cgo/gmp: update for Go 1
1. make the program go buildable
2. update os.EINVAL and runtime.Cgocalls()
3. wrap mpz_div_2exp() and mpz_mul_2exp to support both
   pre-5.0 and post-5.0 gmp (we really have no reason to
   restrict ourselves to gmp 5.0+)

R=golang-dev, remyoudompheng, iant
CC=golang-dev
http://codereview.appspot.com/5847061