Issue 5846074: See http://codereview.appspot.com/5844050/

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5846074: See http://codereview.appspot.com/5844050/ (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by yanivi

Modified:
12 years, 2 months ago

Reviewers:
aiuto, rmistry

Base URL:
https://google-oauth-java-client.googlecode.com/hg/

Visibility:
Public.

Description

See http://codereview.appspot.com/5844050/ Also: remove deprecated HmacSha and RsaSha

Patch Set 1 #

Patch Set 2 : feedback #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -236 lines)			Patch
R	google-oauth-client/src/main/java/com/google/api/client/auth/HmacSha.java	View	1	1 chunk	+0 lines, -52 lines	0 comments	Download
R	google-oauth-client/src/main/java/com/google/api/client/auth/RsaSha.java	View	1	1 chunk	+0 lines, -115 lines	0 comments	Download
M	google-oauth-client/src/main/java/com/google/api/client/auth/jsontoken/JsonWebSignature.java	View	1	5 chunks	+13 lines, -13 lines	0 comments	Download
M	google-oauth-client/src/main/java/com/google/api/client/auth/jsontoken/RsaSHA256Signer.java	View	1	1 chunk	+2 lines, -3 lines	0 comments	Download
M	google-oauth-client/src/main/java/com/google/api/client/auth/oauth/OAuthHmacSigner.java	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	google-oauth-client/src/main/java/com/google/api/client/auth/oauth/OAuthRsaSigner.java	View	1	1 chunk	+2 lines, -3 lines	0 comments	Download
M	google-oauth-client/src/main/java/com/google/api/client/auth/oauth2/TokenResponseException.java	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
R	google-oauth-client/src/main/java/com/google/api/client/auth/package-info.java	View	1	1 chunk	+0 lines, -29 lines	0 comments	Download
M	google-oauth-client/src/main/java/com/google/api/client/auth/security/PrivateKeys.java	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	google-oauth-client/src/test/java/com/google/api/client/auth/oauth/OAuthHmacSignerTest.java	View	1	3 chunks	+5 lines, -9 lines	0 comments	Download
M	google-oauth-client/src/test/java/com/google/api/client/auth/oauth/OAuthRsaSignerTest.java	View	1	3 chunks	+11 lines, -7 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

lgtm

Expand All Messages | Collapse All Messages