code review 5846063: sysycall: remove creds_linux_test.go

sysycall: remove creds_linux_test.go
It is unprecedented to add tests to package syscall, especially
system-specific ones. Not a policy worth changing right before Go 1
is cut.

The sole existing test, passfd_test.go, contains the line
        // +build linux darwin probablyfreebsd probablyopenbsd
which argues that this is not a subject to be undertaking likely.
Note that passfd_test.go also went in just now. It's the only test
in syscall.

Deleting for now, will reconsider after Go 1.

[r, 2012-03-18 21:08:38]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[bradfitz, 2012-03-18 21:12:39]

I don't get it.

So where should such tests go?

I only put "probably" in those because I haven't gotten around to testing
them on those systems yet.


On Sun, Mar 18, 2012 at 2:08 PM, <r@golang.org> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> sysycall: remove creds_linux_test.go
> It is almost unprecedented to add tests to package syscall, especially
> system-specific ones. Not a policy worth changing right before Go 1
> is cut.
>
> The sole existing test, passfd_test.go, contains the line
>        // +build linux darwin probablyfreebsd probablyopenbsd
> which argues that this is not a subject to be undertaking likely.
>
> Deleting for now, can reconsider after Go 1.
>
> Please review this at
http://codereview.appspot.com/**5846063/<http://codereview.appspot.com/5846063/>
>
> Affected files:
>  R src/pkg/syscall/creds_linux_**test.go
>
>
>

[r2, 2012-03-18 21:19:52]

On 19/03/2012, at 8:12 AM, Brad Fitzpatrick wrote:

> I don't get it.
> 
> So where should such tests go?
> 
> I only put "probably" in those because I haven't gotten around to testing them
on those systems yet.

Answered in the other thread.

-rob

[r2, 2012-03-18 21:22:43]

On 19/03/2012, at 8:12 AM, Brad Fitzpatrick wrote:]
> 
> I only put "probably" in those because I haven't gotten around to testing them
on those systems yet.

Those "probably"s go to the heart of my concern. Non-portable code needs testing
as much as portable code, maybe more so, but it cannot be easily tested across
all targets.

After Go 1, we can figure out what should or at least can be done.

-rob

[dsymonds, 2012-03-19 00:14:14]

LGTM

[r, 2012-03-19 00:15:32]

*** Submitted as http://code.google.com/p/go/source/detail?r=087c6e15702e ***

sysycall: remove creds_linux_test.go
It is unprecedented to add tests to package syscall, especially
system-specific ones. Not a policy worth changing right before Go 1
is cut.

The sole existing test, passfd_test.go, contains the line
        // +build linux darwin probablyfreebsd probablyopenbsd
which argues that this is not a subject to be undertaking likely.
Note that passfd_test.go also went in just now. It's the only test
in syscall.

Deleting for now, will reconsider after Go 1.

R=golang-dev, bradfitz, r, dsymonds
CC=golang-dev
http://codereview.appspot.com/5846063