Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(11679)

Issue 5845046: Diffs for change regarding static initializers removal in Protobuf. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by philippe
Modified:
11 years, 11 months ago
Reviewers:
Base URL:
http://monarch-rpc.googlecode.com/svn/trunk
Visibility:
Public.

Description

Diffs for change regarding static initializers removal in Protobuf. This CL MUST NOT be submitted since its only purpose is to provide information used to review CL 5643065. This CL provides: - A side-by-side diff for joystick.pb.*. This is the only LITE_RUNTIME .pb.cc file (most of them are usually not versioned) I found on Google code. The input .proto does not let us see the full impact of the protobuf change (e.g. InitAsDefaultInstance() is empty). - A new pair of files (phonemetadata.pb.{cc,h}), showing the full impact of the protobuf change. Since these files are new, it is harder to see the changes in the generated code (which can be done to some extent by looking at the joystick.pb.* side-by-side diffs). These new files let you see the changes in the inline methods in the generated header. More generally, changes are always surrounded by GOOGLE_PROTOBUF_NO_STATIC_INITIALIZER therefore you can search for that to quickly spot them. Let me know if you would like to have the raw diff (not always easy to read) for the phonemetadata* files.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4502 lines, -6 lines) Patch
M software/c++/talk/examples/monarch-server/joystick.pb.h View 7 chunks +40 lines, -1 line 0 comments Download
M software/c++/talk/examples/monarch-server/joystick.pb.cc View 8 chunks +44 lines, -5 lines 0 comments Download
A software/c++/talk/examples/monarch-server/phonemetadata.pb.h View 1 chunk +2342 lines, -0 lines 0 comments Download
A software/c++/talk/examples/monarch-server/phonemetadata.pb.cc View 1 chunk +2076 lines, -0 lines 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b