Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1527)

Issue 5844052: Autobeaming works properly with tuplet recheck (Issue 2408) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years ago by Carl
Modified:
10 years, 2 months ago
Reviewers:
MikeSol, dak
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Autobeaming works properly with tuplet recheck (Issue 2408) When a new shortest duration is added to a beam, the beam is rechecked for desired division. Prior to this fix, the tuplet multiplication factor was ignored when calculating the duration of each note in the beam during the recheck.

Patch Set 1 : Fix spacing error #

Total comments: 2

Patch Set 2 : Fix memory leak in response to Mike and David #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -5 lines) Patch
A input/regression/autobeam-tuplet-recheck.ly View 1 chunk +16 lines, -0 lines 0 comments Download
M lily/beaming-pattern.cc View 1 2 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 2
MikeSol
http://codereview.appspot.com/5844052/diff/3001/lily/beaming-pattern.cc File lily/beaming-pattern.cc (right): http://codereview.appspot.com/5844052/diff/3001/lily/beaming-pattern.cc#newcode361 lily/beaming-pattern.cc:361: } My comment has nothing to do with your ...
12 years ago (2012-03-21 10:51:29 UTC) #1
dak
12 years ago (2012-03-21 11:00:30 UTC) #2
http://codereview.appspot.com/5844052/diff/3001/lily/beaming-pattern.cc
File lily/beaming-pattern.cc (right):

http://codereview.appspot.com/5844052/diff/3001/lily/beaming-pattern.cc#newco...
lily/beaming-pattern.cc:361: }
On 2012/03/21 10:51:29, MikeSol wrote:
> My comment has nothing to do with your patch but with this function - it seems
> like there's a memory leak with *dur (I know very little about memory
> management, so sorry in advance if I'm totally off...).

No, you are quite correct.  There is no sense in allocating a duration on the
heap here.  It would be simpler to just write
Duration dur (2 + ...); [...] * dur.get_length ();
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b