Issue 5843066: code review 5843066: html/template: add Templates and *Escape functions

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5843066: code review 5843066: html/template: add Templates and *Escape functions (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 1 month ago by r

Modified:
13 years, 1 month ago

Reviewers:

CC:
golang-dev, dsymonds

Visibility:
Public.

Description

html/template: add Templates and *Escape functions to bring it in line with text/template's interface. Fixes issue 3296.

Patch Set 1 #

Patch Set 2 : diff -r f937b86161b7 https://code.google.com/p/go/ #

Patch Set 3 : diff -r fabe3dc4498e https://code.google.com/p/go/ #

Created: 13 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+82 lines, -0 lines)			Patch
M	src/pkg/html/template/clone_test.go	View		1 chunk	+26 lines, -0 lines	0 comments	Download
M	src/pkg/html/template/escape.go	View	1	2 chunks	+42 lines, -0 lines	0 comments	Download
M	src/pkg/html/template/template.go	View		1 chunk	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

13 years, 1 month ago (2012-03-20 03:07:47 UTC) #1

13 years, 1 month ago (2012-03-20 03:38:11 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=f1259609b814 ***

html/template: add Templates and *Escape functions
to bring it in line with text/template's interface.
Fixes issue 3296.

R=golang-dev, dsymonds
CC=golang-dev
http://codereview.appspot.com/5843066

Expand All Messages | Collapse All Messages