Issue 5833049: code review 5833049: runtime: do not handle signals before configuring handler

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5833049: code review 5833049: runtime: do not handle signals before configuring handler (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 1 month ago by rsc

Modified:
13 years, 1 month ago

Reviewers:

CC:
golang-dev, dsymonds, mikio

Visibility:
Public.

Description

runtime: do not handle signals before configuring handler There was a small window during program initialization where a signal could come in before the handling mechanisms were set up to handle it. Delay the signal-handler installation until we're ready for the signals. Fixes issue 3314.

Patch Set 1 #

Patch Set 2 : diff -r aedfd2d76b76 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r aedfd2d76b76 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r 131ae87a607b https://go.googlecode.com/hg/ #

Created: 13 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -6 lines)			Patch
	M	src/pkg/runtime/proc.c	View	1 2 3	2 chunks	+7 lines, -1 line	0 comments	Download
	M	src/pkg/runtime/runtime.c	View	1 2 3	4 chunks	+3 lines, -5 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 1 month ago (2012-03-15 21:39:12 UTC) #1

mikio

LGTM Thank you. http://codereview.appspot.com/5833049/diff/3001/src/pkg/runtime/proc.c File src/pkg/runtime/proc.c (right): http://codereview.appspot.com/5833049/diff/3001/src/pkg/runtime/proc.c#newcode737 src/pkg/runtime/proc.c:737: drop tab

13 years, 1 month ago (2012-03-16 01:14:24 UTC) #3

rsc

13 years, 1 month ago (2012-03-16 02:18:00 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=fe2c533b577b ***

runtime: do not handle signals before configuring handler

There was a small window during program initialization
where a signal could come in before the handling mechanisms
were set up to handle it.  Delay the signal-handler installation
until we're ready for the signals.

Fixes issue 3314.

R=golang-dev, dsymonds, mikioh.mikioh
CC=golang-dev
http://codereview.appspot.com/5833049

Expand All Messages | Collapse All Messages