Issue 5833043: code review 5833043: goprotobuf: fix compiler golden test

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5833043: code review 5833043: goprotobuf: fix compiler golden test (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 8 months ago by dsymonds

Modified:
13 years, 8 months ago

Reviewers:
r2

CC:
r, golang-dev

Visibility:
Public.

Description

goprotobuf: fix compiler golden test

Patch Set 1 #

Patch Set 2 : diff -r 07a39af1fd9f https://code.google.com/p/goprotobuf #

Patch Set 3 : diff -r 07a39af1fd9f https://code.google.com/p/goprotobuf #

Created: 13 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+378 lines, -146 lines)			Patch
M	Makefile	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	protoc-gen-go/testdata/Makefile	View	1	1 chunk	+7 lines, -16 lines	0 comments	Download
A	protoc-gen-go/testdata/multi/multi1.proto	View	1	1 chunk	+42 lines, -0 lines	0 comments	Download
A	protoc-gen-go/testdata/multi/multi2.proto	View	1	1 chunk	+44 lines, -0 lines	0 comments	Download
A	protoc-gen-go/testdata/multi/multi3.proto	View	1	1 chunk	+41 lines, -0 lines	0 comments	Download
R	protoc-gen-go/testdata/multi1.proto	View	1	1 chunk	+0 lines, -42 lines	0 comments	Download
R	protoc-gen-go/testdata/multi2.proto	View	1	1 chunk	+0 lines, -44 lines	0 comments	Download
R	protoc-gen-go/testdata/multi3.proto	View	1	1 chunk	+0 lines, -41 lines	0 comments	Download
M	protoc-gen-go/testdata/my_test/test.proto	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	protoc-gen-go/testdata/my_test/test.pb.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
A	protoc-gen-go/testdata/my_test/test.pb.go.golden	View	1	1 chunk	+241 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dsymonds

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/goprotobuf

13 years, 8 months ago (2012-03-15 04:23:56 UTC) #1

dsymonds

*** Submitted as http://code.google.com/p/goprotobuf/source/detail?r=876786899c70 *** goprotobuf: fix compiler golden test TBR=r CC=golang-dev http://codereview.appspot.com/5833043

13 years, 8 months ago (2012-03-15 04:24:04 UTC) #2

LGTM

Expand All Messages | Collapse All Messages