Issue 5832043: code review 5832043: goprotobuf: Use local imports for testdata package.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5832043: code review 5832043: goprotobuf: Use local imports for testdata package. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 8 months ago by dsymonds

Modified:
13 years, 7 months ago

Reviewers:
rsc, r2, albert.strasheim

CC:
r, golang-dev

Visibility:
Public.

Description

goprotobuf: Use local imports for testdata package.

Patch Set 1 #

Patch Set 2 : diff -r dcedd8c5e14c https://code.google.com/p/goprotobuf #

Created: 13 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
M	proto/all_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	proto/clone_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	proto/equal_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	proto/text_parser_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	proto/text_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

dsymonds

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/goprotobuf

13 years, 8 months ago (2012-03-15 04:10:21 UTC) #1

dsymonds

*** Submitted as http://code.google.com/p/goprotobuf/source/detail?r=07a39af1fd9f *** goprotobuf: Use local imports for testdata package. TBR=r CC=golang-dev http://codereview.appspot.com/5832043

13 years, 8 months ago (2012-03-15 04:10:30 UTC) #2

albert.strasheim

Hello On Thursday, March 15, 2012 6:10:30 AM UTC+2, David Symonds wrote: > > *** ...

13 years, 7 months ago (2012-03-16 13:34:30 UTC) #5

13 years, 7 months ago (2012-03-17 04:35:20 UTC) #6

On 17/03/2012, at 12:34 AM, Albert Strasheim wrote:

> Hello
> 
> On Thursday, March 15, 2012 6:10:30 AM UTC+2, David Symonds wrote:
> *** Submitted as
> http://code.google.com/p/goprotobuf/source/detail?r=07a39af1fd9f ***
> goprotobuf: Use local imports for testdata package.
> 
> Sadly, this breaks the build on gccgo.

Does it break the build?  Tests I can believe but surely the build is OK.

-rob

Expand All Messages | Collapse All Messages