code review 5831043: os: return some invented data from Stat(DevNull) on windows

os: return some invented data from Stat(DevNull) on windows

Fixes issue 3321.

[brainman, 2012-03-15 03:19:16]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2012-03-15 03:29:01]

LGTM

http://codereview.appspot.com/5831043/diff/2002/src/pkg/os/stat_windows.go
File src/pkg/os/stat_windows.go (right):

http://codereview.appspot.com/5831043/diff/2002/src/pkg/os/stat_windows.go#ne...
src/pkg/os/stat_windows.go:85: modTime: time.Now(),
I'd remove this line.  a zero time seems better.

[brainman, 2012-03-15 05:33:51]

*** Submitted as http://code.google.com/p/go/source/detail?r=f04024741479 ***

os: return some invented data from Stat(DevNull) on windows

Fixes issue 3321.

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/5831043

http://codereview.appspot.com/5831043/diff/2002/src/pkg/os/stat_windows.go
File src/pkg/os/stat_windows.go (right):

http://codereview.appspot.com/5831043/diff/2002/src/pkg/os/stat_windows.go#ne...
src/pkg/os/stat_windows.go:85: modTime: time.Now(),
On 2012/03/15 03:29:01, bradfitz wrote:
> I'd remove this line.  a zero time seems better.

Done.

[bsiegert, 2012-03-15 12:04:16]

http://codereview.appspot.com/5831043/diff/5003/src/pkg/os/stat_windows.go
File src/pkg/os/stat_windows.go (right):

http://codereview.appspot.com/5831043/diff/5003/src/pkg/os/stat_windows.go#ne...
src/pkg/os/stat_windows.go:86: // hopefully this will work for SameFile
test?

[brainman, 2012-03-16 06:10:56]

http://codereview.appspot.com/5831043/diff/5003/src/pkg/os/stat_windows.go
File src/pkg/os/stat_windows.go (right):

http://codereview.appspot.com/5831043/diff/5003/src/pkg/os/stat_windows.go#ne...
src/pkg/os/stat_windows.go:86: // hopefully this will work for SameFile
On 2012/03/15 12:04:16, bsiegert wrote:
> test?

Was thinking about that, but I can't come up with anything worth doing. I can
compare DevNull with any real file in current directory, but I know it will
work, because real files has non 0 VolumeSerialNumber, FileIndexHigh and
FileIndexLow. I can compare DevNull with itself, but that is even more trivial.

Alex