Issue 583043: code review 583043: acme: attempt to fix Put mtime skew on NFS

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 583043: code review 583043: acme: attempt to fix Put mtime skew on NFS (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 10 months ago by rsc

Modified:
14 years, 10 months ago

Reviewers:

CC:
r

Visibility:
Public.

Description

acme: attempt to fix Put mtime skew on NFS

Patch Set 2 : code review 583043: acme: attempt to fix Put mtime skew on NFS #

Created: 14 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -0 lines)			Patch
	M	src/cmd/acme/exec.c	View	1	1 chunk	+13 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

LGTM http://codereview.appspot.com/583043/diff/1/2 File src/cmd/acme/exec.c (right): http://codereview.appspot.com/583043/diff/1/2#newcode692 src/cmd/acme/exec.c:692: // to be updated. The file is already ...

14 years, 10 months ago (2010-03-16 23:39:58 UTC) #2

rsc

14 years, 10 months ago (2010-03-19 01:08:09 UTC) #3

*** Submitted as 4ecd953ed2bb ***

acme: attempt to fix Put mtime skew on NFS

R=r
http://codereview.appspot.com/583043

Expand All Messages | Collapse All Messages