code review 5823045: misc/dist: force modes to 0755 or 0644 in tarballs

misc/dist: force modes to 0755 or 0644 in tarballs

[adg, 2012-03-14 06:03:18]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[dsymonds, 2012-03-14 06:05:25]

http://codereview.appspot.com/5823045/diff/1/misc/dist/bindist.go
File misc/dist/bindist.go (right):

http://codereview.appspot.com/5823045/diff/1/misc/dist/bindist.go#newcode540
misc/dist/bindist.go:540: if hdr.Mode|0111 != 0 {
s/|/&/ right?

[dsymonds, 2012-03-14 06:06:26]

Modulo the wrong binary operator, LGTM.

[adg, 2012-03-14 06:09:20]

*** Submitted as http://code.google.com/p/go/source/detail?r=11f6f0da51f6 ***

misc/dist: force modes to 0755 or 0644 in tarballs

R=golang-dev, dsymonds
CC=golang-dev
http://codereview.appspot.com/5823045

http://codereview.appspot.com/5823045/diff/1/misc/dist/bindist.go
File misc/dist/bindist.go (right):

http://codereview.appspot.com/5823045/diff/1/misc/dist/bindist.go#newcode540
misc/dist/bindist.go:540: if hdr.Mode|0111 != 0 {
On 2012/03/14 06:05:26, dsymonds wrote:
> s/|/&/ right?

Yes, of course.

[bradfitz, 2012-03-14 14:34:12]

This is wrong.

Mode != Permission.  You're destroying the C_ISREG, etc bits on Mode.


On Tue, Mar 13, 2012 at 11:09 PM, <adg@golang.org> wrote:

> *** Submitted as
>
http://code.google.com/p/go/**source/detail?r=11f6f0da51f6<http://code.google...
>
>
> misc/dist: force modes to 0755 or 0644 in tarballs
>
> R=golang-dev, dsymonds
> CC=golang-dev
> http://codereview.appspot.com/**5823045<http://codereview.appspot.com/5823045>
>
>
>
>
>
http://codereview.appspot.com/**5823045/diff/1/misc/dist/**bindist.go<http://...
> File misc/dist/bindist.go (right):
>
> http://codereview.appspot.com/**5823045/diff/1/misc/dist/**
>
bindist.go#newcode540<http://codereview.appspot.com/5823045/diff/1/misc/dist/bindist.go#newcode540>
> misc/dist/bindist.go:540: if hdr.Mode|0111 != 0 {
> On 2012/03/14 06:05:26, dsymonds wrote:
>
>> s/|/&/ right?
>>
>
> Yes, of course.
>
>
http://codereview.appspot.com/**5823045/<http://codereview.appspot.com/5823045/>
>

[bradfitz, 2012-03-14 14:50:32]

See
http://codereview.appspot.com/**5822046/<http://codereview.appspot.com/5822046/>

On Wed, Mar 14, 2012 at 7:34 AM, Brad Fitzpatrick <bradfitz@golang.org>wrote:

> This is wrong.
>
> Mode != Permission.  You're destroying the C_ISREG, etc bits on Mode.
>
>
> On Tue, Mar 13, 2012 at 11:09 PM, <adg@golang.org> wrote:
>
>> *** Submitted as
>>
http://code.google.com/p/go/**source/detail?r=11f6f0da51f6<http://code.google...
>>
>>
>> misc/dist: force modes to 0755 or 0644 in tarballs
>>
>> R=golang-dev, dsymonds
>> CC=golang-dev
>>
http://codereview.appspot.com/**5823045<http://codereview.appspot.com/5823045>
>>
>>
>>
>>
>>
http://codereview.appspot.com/**5823045/diff/1/misc/dist/**bindist.go<http://...
>> File misc/dist/bindist.go (right):
>>
>> http://codereview.appspot.com/**5823045/diff/1/misc/dist/**
>>
bindist.go#newcode540<http://codereview.appspot.com/5823045/diff/1/misc/dist/bindist.go#newcode540>
>> misc/dist/bindist.go:540: if hdr.Mode|0111 != 0 {
>> On 2012/03/14 06:05:26, dsymonds wrote:
>>
>>> s/|/&/ right?
>>>
>>
>> Yes, of course.
>>
>>
http://codereview.appspot.com/**5823045/<http://codereview.appspot.com/5823045/>
>>
>
>