Issue 5820063: Downgrade non-lockable class requirement on thread safety attributes from error to warning.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5820063: Downgrade non-lockable class requirement on thread safety attributes from error to warning.

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by delesley

Modified:
9 years, 4 months ago

Reviewers:
Richard Smith

Visibility:
Public.

Patch Set 1 #

Total comments: 1

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+70 lines, -70 lines)			Patch
M	include/clang/Basic/DiagnosticSemaKinds.td	View	1 chunk	+9 lines, -4 lines	0 comments	Download
M	lib/Sema/SemaDeclAttr.cpp	View	5 chunks	+12 lines, -17 lines	1 comment	Download
M	test/SemaCXX/warn-thread-safety-parsing.cpp	View	13 chunks	+49 lines, -49 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

Richard Smith

12 years, 1 month ago (2012-03-22 00:09:02 UTC) #1

http://codereview.appspot.com/5820063/diff/1/lib/Sema/SemaDeclAttr.cpp
File lib/Sema/SemaDeclAttr.cpp (right):

http://codereview.appspot.com/5820063/diff/1/lib/Sema/SemaDeclAttr.cpp#newcod...
lib/Sema/SemaDeclAttr.cpp:399: }
You can drop the braces here.

Expand All Messages | Collapse All Messages