Issue 5820048: code review 5820048: doc: add reference to FAQ to explain warning about conc...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5820048: code review 5820048: doc: add reference to FAQ to explain warning about conc... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 1 month ago by Stefan Nilsson

Modified:
13 years, 1 month ago

Reviewers:

CC:
golang-dev, adg

Visibility:
Public.

Description

doc: add reference to FAQ to explain warning about concrete type

Patch Set 2 : diff -r ca61f2a46162 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r ca61f2a46162 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r 2778eee8110b https://go.googlecode.com/hg/ #

Created: 13 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	doc/articles/error_handling.html	View	1 2 3	1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Stefan Nilsson

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 1 month ago (2012-03-14 10:47:28 UTC) #1

adg

http://codereview.appspot.com/5820048/diff/3/doc/articles/error_handling.html File doc/articles/error_handling.html (right): http://codereview.appspot.com/5820048/diff/3/doc/articles/error_handling.html#newcode262 doc/articles/error_handling.html:262: see <a href="/doc/go_faq.html#nil_error">Why is my nil error value not ...

13 years, 1 month ago (2012-03-14 12:48:19 UTC) #2

Stefan Nilsson

Hello golang-dev@googlegroups.com, adg@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

13 years, 1 month ago (2012-03-14 13:49:35 UTC) #3

adg

13 years, 1 month ago (2012-03-14 22:15:22 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=fd6a99a55adc ***

doc: add reference to FAQ to explain warning about concrete type

R=golang-dev, adg
CC=golang-dev
http://codereview.appspot.com/5820048

Committer: Andrew Gerrand <adg@golang.org>

Expand All Messages | Collapse All Messages