code review 5796064: misc/dist: use archive/tar to generate tarballs

misc/dist: use archive/tar to generate tarballs

For people untarring with -p or as root, preserving file permissions.
This way we don't make tars owned by adg/eng or adg/staff or whatever
machine Andrew was on. Instead, we always build tarballs owned by predictable
users.

Except archive/tar doesn't seem to work.

Updates issue 3209.

[bradfitz, 2012-03-12 05:41:56]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[adg, 2012-03-12 05:50:31]

LGTM

http://codereview.appspot.com/5796064/diff/2003/misc/dist/bindist.go
File misc/dist/bindist.go (right):

http://codereview.appspot.com/5796064/diff/2003/misc/dist/bindist.go#newcode512
misc/dist/bindist.go:512: zout := zlib.NewWriter(f)
s/zlib/gzip/

http://codereview.appspot.com/5796064/diff/2003/misc/dist/bindist.go#newcode545
misc/dist/bindist.go:545: Uid:      0, // explicitly not setting this
drop the comment. we _are_ setting it, to zero

[bradfitz, 2012-03-12 05:50:36]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

Please take another look.

[adg, 2012-03-12 05:52:47]

LGTM

http://codereview.appspot.com/5796064/diff/6001/misc/dist/bindist.go
File misc/dist/bindist.go (right):

http://codereview.appspot.com/5796064/diff/6001/misc/dist/bindist.go#newcode38
misc/dist/bindist.go:38: // TODO(bradfitz,dsymonds,adg): remove this flag once
archive/tar Writer works.
put only dsymonds in this todo

[bradfitz, 2012-03-12 06:07:40]

*** Submitted as http://code.google.com/p/go/source/detail?r=c7af497373ff ***

misc/dist: use archive/tar to generate tarballs

For people untarring with -p or as root, preserving file permissions.
This way we don't make tars owned by adg/eng or adg/staff or whatever
machine Andrew was on. Instead, we always build tarballs owned by predictable
users.

Except archive/tar doesn't seem to work.

Updates issue 3209.

R=golang-dev, adg
CC=dsymonds, golang-dev
http://codereview.appspot.com/5796064

[dsymonds, 2012-03-12 06:08:30]

http://codereview.appspot.com/5796064/diff/6001/misc/dist/bindist.go
File misc/dist/bindist.go (right):

http://codereview.appspot.com/5796064/diff/6001/misc/dist/bindist.go#newcode547
misc/dist/bindist.go:547: Size:     fi.Size(),
This should be zero for the fi.IsDir() case, because you're not writing anything
after this header. That's what's causing the bad tar.

I'll make archive/tar return an error if you do a short write so that this will
break instead of silently producing a bad file.