Issue 5795070: Increase test coverage.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5795070: Increase test coverage. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years ago by jcgregorio_google

Modified:
14 years ago

Reviewers:
aiuto, jcgregorio_google

CC:
google-api-python-client_googlegroups.com

Visibility:
Public.

Patch Set 3 : updte #

Created: 14 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+211 lines, -10 lines)			Patch
M	Makefile	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	oauth2client/appengine.py	View		2 chunks	+4 lines, -2 lines	0 comments	Download
M	oauth2client/client.py	View		2 chunks	+15 lines, -1 line	0 comments	Download
M	runtests.py	View		1 chunk	+4 lines, -3 lines	0 comments	Download
A	tests/data/client_secrets.json	View		1 chunk	+9 lines, -0 lines	0 comments	Download
A	tests/data/unfilled_client_secrets.json	View		1 chunk	+9 lines, -0 lines	0 comments	Download
M	tests/test_oauth2client.py	View		5 chunks	+24 lines, -0 lines	0 comments	Download
M	tests/test_oauth2client_appengine.py	View	1 2	8 chunks	+138 lines, -4 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

aiuto

lgtm What did the coverage go up to? http://codereview.appspot.com/5795070/diff/2001/tests/test_oauth2client_appengine.py File tests/test_oauth2client_appengine.py (right): http://codereview.appspot.com/5795070/diff/2001/tests/test_oauth2client_appengine.py#newcode67 tests/test_oauth2client_appengine.py:67: extra ...

14 years ago (2012-03-13 20:31:41 UTC) #2

jcgregorio_google

Raised coverage of oauth2client.appengine from 75% to 94%. http://codereview.appspot.com/5795070/diff/2001/tests/test_oauth2client_appengine.py File tests/test_oauth2client_appengine.py (right): http://codereview.appspot.com/5795070/diff/2001/tests/test_oauth2client_appengine.py#newcode67 tests/test_oauth2client_appengine.py:67: On ...

14 years ago (2012-03-14 04:07:39 UTC) #3

jcgregorio_google

14 years ago (2012-03-14 04:10:57 UTC) #4

Committed at
http://code.google.com/p/google-api-python-client/source/detail?r=e4540b08728...

Expand All Messages | Collapse All Messages