Issue 5795059: code review 5795059: os: document FileInfo.Size as undefined for irregular files

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5795059: code review 5795059: os: document FileInfo.Size as undefined for irregular files (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 1 month ago by bradfitz

Modified:
13 years, 1 month ago

Reviewers:

CC:
rsc, r, golang-dev

Visibility:
Public.

Description

os: document FileInfo.Size as system-dependent for irregular files

Patch Set 1 #

Patch Set 2 : diff -r ee6ef7631ce4 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r ee6ef7631ce4 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r ee6ef7631ce4 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 5 : diff -r 0f4f12f8e239 https://go.googlecode.com/hg #

Created: 13 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/pkg/os/types.go	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 1 month ago (2012-03-12 17:23:10 UTC) #1

bradfitz

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.

13 years, 1 month ago (2012-03-12 17:35:55 UTC) #2

LGTM with my rewriting. state what works, not what doesn't, because the second list is ...

13 years, 1 month ago (2012-03-12 20:14:53 UTC) #4

bradfitz

13 years, 1 month ago (2012-03-12 20:17:50 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=452465a5f105 ***

os: document FileInfo.Size as system-dependent for irregular files

R=rsc, r
CC=golang-dev
http://codereview.appspot.com/5795059

Expand All Messages | Collapse All Messages