Issue 5792043: code review 5792043: cmd/gofmt: fix race in long test

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5792043: code review 5792043: cmd/gofmt: fix race in long test (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 2 months ago by mikio

Modified:
13 years, 2 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

cmd/gofmt: fix race in long test Fixes issue 3249.

Patch Set 1 : diff -r ea632887b22a https://go.googlecode.com/hg/ #

Patch Set 2 : diff -r ea632887b22a https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r f147fef4e17c https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r f147fef4e17c https://go.googlecode.com/hg/ #

Created: 13 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -10 lines)			Patch
	M	src/cmd/gofmt/gofmt.go	View		4 chunks	+5 lines, -5 lines	0 comments	Download
	M	src/cmd/gofmt/long_test.go	View	1 2	5 chunks	+7 lines, -5 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

mikio

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 2 months ago (2012-03-08 13:17:03 UTC) #1

mikio

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.

13 years, 2 months ago (2012-03-08 14:39:26 UTC) #2

mikio

13 years, 2 months ago (2012-03-08 14:56:30 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=38bd0efc99a0 ***

cmd/gofmt: fix race in long test

Fixes issue 3249.

R=rsc
CC=golang-dev
http://codereview.appspot.com/5792043

Expand All Messages | Collapse All Messages