Issue 5786060: code review 5786060: go/printer, gofmt: nicer formatting of multi-line returns

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5786060: code review 5786060: go/printer, gofmt: nicer formatting of multi-line returns (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 2 months ago by gri

Modified:
13 years, 2 months ago

Reviewers:

CC:
dsymonds, rsc, golang-dev

Visibility:
Public.

Description

go/printer, gofmt: nicer formatting of multi-line returns This affects corner (test) cases only; gofmt -w src misc doesn't cause any changes. - added additional test cases - removed doIndent parameter from printer.valueSpec (was always false) - gofmt -w src misc causes no changes Fixes issue 1207.

Patch Set 1 #

Patch Set 2 : diff -r ccbc7503da53 https://code.google.com/p/go #

Patch Set 3 : diff -r ccbc7503da53 https://code.google.com/p/go #

Patch Set 4 : diff -r ccbc7503da53 https://code.google.com/p/go #

Patch Set 5 : diff -r b266610f1677 https://code.google.com/p/go #

Created: 13 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+145 lines, -13 lines)			Patch
M	src/pkg/go/printer/nodes.go	View	1 2	5 chunks	+51 lines, -5 lines	0 comments	Download
M	src/pkg/go/printer/testdata/statements.golden	View	1	3 chunks	+51 lines, -8 lines	0 comments	Download
M	src/pkg/go/printer/testdata/statements.input	View	1	2 chunks	+43 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

gri

Hello dsymonds@golang.org, rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

13 years, 2 months ago (2012-03-09 01:08:32 UTC) #1

dsymonds

LGTM Can't really speak for the code change, and haven't thought thoroughly about the heuristic, ...

13 years, 2 months ago (2012-03-09 02:14:22 UTC) #2

gri

13 years, 2 months ago (2012-03-09 19:05:54 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=20edbffdf421 ***

go/printer, gofmt: nicer formatting of multi-line returns

This affects corner (test) cases only; gofmt -w src misc
doesn't cause any changes.

- added additional test cases
- removed doIndent parameter from printer.valueSpec
  (was always false)
- gofmt -w src misc causes no changes

Fixes issue 1207.

R=dsymonds, rsc
CC=golang-dev
http://codereview.appspot.com/5786060

Expand All Messages | Collapse All Messages