Issue 5786055: code review 5786055: test: skip . files in directory

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5786055: code review 5786055: test: skip . files in directory (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 2 months ago by rsc

Modified:
13 years, 2 months ago

Reviewers:

CC:
golang-dev, gri

Visibility:
Public.

Description

test: skip . files in directory Xcode generates ._foo.go files.

Patch Set 2 : diff -r 9974201aa263 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 9974201aa263 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r 66caae9a7ddb https://go.googlecode.com/hg/ #

Created: 13 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -7 lines)			Patch
	M	test/run.go	View	1 2 3	5 chunks	+7 lines, -7 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 2 months ago (2012-03-08 19:00:02 UTC) #1

gri

LGTM http://codereview.appspot.com/5786055/diff/3001/test/run.go File test/run.go (right): http://codereview.appspot.com/5786055/diff/3001/test/run.go#newcode150 test/run.go:150: if !strings.HasPrefix(name, ".") && strings.HasSuffix(name, ".go") { We ...

13 years, 2 months ago (2012-03-08 19:02:32 UTC) #2

rsc

We do it in fewer places every day. Things reading whole packages should use build.ImportDir ...

13 years, 2 months ago (2012-03-08 19:03:19 UTC) #3

rsc

13 years, 2 months ago (2012-03-08 19:03:43 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=d3b7f8ade3cd ***

test: skip . files in directory

Xcode generates ._foo.go files.

R=golang-dev, gri
CC=golang-dev
http://codereview.appspot.com/5786055

Expand All Messages | Collapse All Messages