code review 5785053: cmd/go: add env command, use to fix misc/cgo/testso

cmd/go: add env command, use to fix misc/cgo/testso

Fixes 386 build on 64-bit machines.

[rsc, 2012-03-08 19:00:17]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2012-03-08 19:05:01]

LGTM

On Thu, Mar 8, 2012 at 11:00 AM, <rsc@golang.org> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> cmd/go: add env command, use to fix misc/cgo/testso
>
> Fixes 386 build on 64-bit machines.
>
> Please review this at
http://codereview.appspot.com/**5785053/<http://codereview.appspot.com/5785053/>
>
> Affected files:
>  M src/cmd/go/doc.go
>  A src/cmd/go/env.go
>  M src/cmd/go/main.go
>
>
>

[minux1, 2012-03-08 19:06:22]

Rietveld says: "error: old chunk mismatch" whenever I click on View side-by-side
diffs.

[bradfitz, 2012-03-08 19:06:58]

Yeah, I saw that too, but you can just look at the full unified diff.

On Thu, Mar 8, 2012 at 11:06 AM, <minux.ma@gmail.com> wrote:

> Rietveld says: "error: old chunk mismatch" whenever I click on View
> side-by-side diffs.
>
>
http://codereview.appspot.com/**5785053/<http://codereview.appspot.com/5785053/>
>

[minux1, 2012-03-08 19:10:59]

cmd/go/env.go, Line 45:
+		{"GOGCCFLAGS", strings.Join(b.gccCmd(".")[3:], " ")},
     I'm worried about the hardcoded number here.

[rsc, 2012-03-08 19:16:17]

On Thu, Mar 8, 2012 at 14:10,  <minux.ma@gmail.com> wrote:
> +               {"GOGCCFLAGS", strings.Join(b.gccCmd(".")[3:], " ")},
>     I'm worried about the hardcoded number here.

I commented it in the other place.  I think that's enough for now.

[minux1, 2012-03-08 19:22:02]

On 2012/03/08 19:16:17, rsc wrote:
> On Thu, Mar 8, 2012 at 14:10,  <mailto:minux.ma@gmail.com> wrote:
> > &nbsp; &nbsp; I'm worried about the hardcoded number here. 
> I commented it in the other place.  I think that's enough for now.
Sure. LGTM.

[rsc, 2012-03-08 19:28:58]

*** Submitted as http://code.google.com/p/go/source/detail?r=f09a59559605 ***

cmd/go: add env command, use to fix misc/cgo/testso

Fixes 386 build on 64-bit machines.

R=golang-dev, bradfitz, minux.ma
CC=golang-dev
http://codereview.appspot.com/5785053