Issue 5785049: code review 5785049: cmd/gc: implement len(array) / cap(array) rule

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5785049: code review 5785049: cmd/gc: implement len(array) / cap(array) rule (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 2 months ago by rsc

Modified:
13 years, 2 months ago

Reviewers:
ken3

CC:
ken2, golang-dev

Visibility:
Public.

Description

cmd/gc: implement len(array) / cap(array) rule The spec is looser than the current implementation. The spec edit was made in CL 4444050 (May 2011) but I never implemented it. Fixes issue 3244.

Patch Set 1 #

Patch Set 2 : diff -r da7ac33e249e https://code.google.com/p/go/ #

Patch Set 3 : diff -r 83e8f7f6d029 https://code.google.com/p/go/ #

Created: 13 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+158 lines, -6 lines)			Patch
M	src/cmd/gc/typecheck.c	View	1	2 chunks	+48 lines, -6 lines	0 comments	Download
A	test/const4.go	View	1	1 chunk	+77 lines, -0 lines	0 comments	Download
A	test/const5.go	View	1	1 chunk	+33 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

13 years, 2 months ago (2012-03-08 03:43:26 UTC) #1

rsc

*** Submitted as f25b7abf4c99 *** cmd/gc: implement len(array) / cap(array) rule The spec is looser ...

13 years, 2 months ago (2012-03-08 03:43:31 UTC) #2

lgtm

Expand All Messages | Collapse All Messages