code review 5784065: cmd/gc: import path cannot start with slash on Windows

cmd/gc: import path cannot start with slash on Windows
        For CL 5756065.

[minux1, 2012-03-09 09:22:16]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[rsc, 2012-03-09 19:24:53]

This suggests that islocalname("/") is false on Windows.
Can we fix that instead?

[minux1, 2012-03-09 20:04:37]

PTAL.
On 2012/03/09 19:24:53, rsc wrote:
> This suggests that islocalname("/") is false on Windows.
> Can we fix that instead?
Related code:
    if(!windows && name->len >= 1 && name->s[0] == '/') 
        return 1;
    if(windows && name->len >= 3 && 
       yy_isalpha(name->s[0]) && name->s[1] == ':' && name->s[2] == '/') 
        return 1;
There is a complication here, IMO, I would just delete the second
if and remove the !windows in the first if. What do you think?

[rsc, 2012-03-09 20:09:22]

> Related code:
>    if(!windows && name->len >= 1 && name->s[0] == '/')
>        return 1;
>    if(windows && name->len >= 3 &&
>       yy_isalpha(name->s[0]) && name->s[1] == ':' && name->s[2] == '/')
>
>        return 1;
> There is a complication here, IMO, I would just delete the second
> if and remove the !windows in the first if. What do you think?

Please remove the !windows in the first, but keep the second for now.

[minux1, 2012-03-09 20:19:31]

PTAL.
On 2012/03/09 20:09:22, rsc wrote:
> Please remove the !windows in the first, but keep the second for now.
I think giving the error "import path can not be absolute path" when user import
"/some",
is somewhat confusing to a Windows user, do we need to explain it further?

[rsc, 2012-03-09 21:10:22]

LGTM

I think the message is okay.

[minux1, 2012-03-09 21:12:01]

*** Submitted as http://code.google.com/p/go/source/detail?r=7574ac0a8014 ***

cmd/gc: import path cannot start with slash on Windows
        For CL 5756065.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/5784065