Issue 5784051: code review 5784051: net: document ReadMsgUnix, WriteMsgUnix

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5784051: code review 5784051: net: document ReadMsgUnix, WriteMsgUnix (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 2 months ago by rsc

Modified:
13 years, 2 months ago

Reviewers:

CC:
golang-dev, jsing

Visibility:
Public.

Description

net: document ReadMsgUnix, WriteMsgUnix Fixes issue 3247.

Patch Set 2 : diff -r f25b7abf4c99 https://code.google.com/p/go/ #

Patch Set 3 : diff -r f25b7abf4c99 https://code.google.com/p/go/ #

Patch Set 4 : diff -r f25b7abf4c99 https://code.google.com/p/go/ #

Total comments: 3

Patch Set 5 : diff -r f3cb8f687738 https://code.google.com/p/go/ #

Created: 13 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -2 lines)			Patch
	M	src/pkg/net/unixsock_posix.go	View	1 2 3 4	3 chunks	+10 lines, -2 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

13 years, 2 months ago (2012-03-08 12:55:48 UTC) #1

rsc

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.

13 years, 2 months ago (2012-03-08 12:59:52 UTC) #2

jsing

LGTM http://codereview.appspot.com/5784051/diff/4002/src/pkg/net/unixsock_posix.go File src/pkg/net/unixsock_posix.go (right): http://codereview.appspot.com/5784051/diff/4002/src/pkg/net/unixsock_posix.go#newcode270 src/pkg/net/unixsock_posix.go:270: // bytes copied into oob, the flags that ...

13 years, 2 months ago (2012-03-08 13:27:22 UTC) #3

rsc

On Thu, Mar 8, 2012 at 08:27, <jsing@google.com> wrote: > that were on the packet, ...

13 years, 2 months ago (2012-03-08 13:36:09 UTC) #4

rsc

13 years, 2 months ago (2012-03-08 13:36:45 UTC) #5

*** Submitted as f11a5787c462 ***

net: document ReadMsgUnix, WriteMsgUnix

Fixes issue 3247.

R=golang-dev, jsing
CC=golang-dev
http://codereview.appspot.com/5784051

Expand All Messages | Collapse All Messages