Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1205)

Issue 5782043: code review 5782043: doc: various update to command documents (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 2 months ago by minux1
Modified:
13 years, 2 months ago
Reviewers:
CC:
golang-dev, r, rsc
Visibility:
Public.

Description

doc: various update to command documents 1. consistent usage section (go tool xxx) 2. reformat cmd/ld document with minor correction document which -H flags are valid on which ld document -d flag can't be used on Windows. document -Hwindowsgui

Patch Set 1 #

Patch Set 2 : diff -r ac558ba56c4e https://code.google.com/p/go/ #

Total comments: 6

Patch Set 3 : diff -r ea632887b22a https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r ea632887b22a https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 4bd78126598b https://code.google.com/p/go/ #

Patch Set 6 : diff -r c053986a1184 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -34 lines) Patch
M src/cmd/gc/doc.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/ld/doc.go View 1 2 3 4 1 chunk +39 lines, -32 lines 0 comments Download
M src/cmd/nm/doc.go View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7
minux1
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
13 years, 2 months ago (2012-03-07 20:51:32 UTC) #1
r
http://codereview.appspot.com/5782043/diff/1001/src/cmd/ld/doc.go File src/cmd/ld/doc.go (right): http://codereview.appspot.com/5782043/diff/1001/src/cmd/ld/doc.go#newcode12 src/cmd/ld/doc.go:12: architecture (5.out, 6.out, 8.out) by default (if $GOOS is ...
13 years, 2 months ago (2012-03-08 01:48:41 UTC) #2
minux1
PTAL. On 2012/03/08 01:48:41, r wrote: http://codereview.appspot.com/5782043/diff/1001/src/cmd/ld/doc.go#newcode12 > src/cmd/ld/doc.go:12: architecture (5.out, 6.out, 8.out) by default ...
13 years, 2 months ago (2012-03-08 13:40:46 UTC) #3
rsc
On Thu, Mar 8, 2012 at 08:40, <minux.ma@gmail.com> wrote: > I dropped the sentence in ...
13 years, 2 months ago (2012-03-08 15:27:19 UTC) #4
minux1
PTAL. On 2012/03/08 15:27:19, rsc wrote: > On Thu, Mar 8, 2012 at 08:40, <mailto:minux.ma@gmail.com> ...
13 years, 2 months ago (2012-03-08 16:48:26 UTC) #5
rsc
LGTM
13 years, 2 months ago (2012-03-08 17:01:05 UTC) #6
minux1
13 years, 2 months ago (2012-03-08 17:31:25 UTC) #7
*** Submitted as http://code.google.com/p/go/source/detail?r=33bbc540c840 ***

doc: various update to command documents
        1. consistent usage section (go tool xxx)
        2. reformat cmd/ld document with minor correction
           document which -H flags are valid on which ld
           document -d flag can't be used on Windows.
           document -Hwindowsgui

R=golang-dev, r, rsc
CC=golang-dev
http://codereview.appspot.com/5782043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b