Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(303)

Issue 5777071: code review 5777071: godoc: added alt attribute to the "pop out" button (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 1 month ago by fss
Modified:
13 years, 1 month ago
Reviewers:
CC:
adg, golang-dev
Visibility:
Public.

Description

godoc: added alt and title attributes to the "pop out" button

Patch Set 1 #

Patch Set 2 : diff -r 97d498d864a3 https://code.google.com/p/go #

Patch Set 3 : diff -r 97d498d864a3 https://code.google.com/p/go #

Patch Set 4 : diff -r 97d498d864a3 https://code.google.com/p/go #

Patch Set 5 : diff -r e9413993dcbe https://code.google.com/p/go #

Patch Set 6 : diff -r e9413993dcbe https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M doc/root.html View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7
fss
Hello adg@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
13 years, 1 month ago (2012-03-13 00:41:33 UTC) #1
adg
Should it be an alt or title attribute? "View full screen" is sufficient, I think.
13 years, 1 month ago (2012-03-13 00:58:15 UTC) #2
fss
On Mon, Mar 12, 2012 at 9:57 PM, Andrew Gerrand <adg@golang.org> wrote: > Should it ...
13 years, 1 month ago (2012-03-13 01:10:41 UTC) #3
adg
On 13 March 2012 12:10, Francisco Souza <franciscossouza@gmail.com> wrote: > On Mon, Mar 12, 2012 ...
13 years, 1 month ago (2012-03-13 01:37:48 UTC) #4
fss
Hello adg@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
13 years, 1 month ago (2012-03-13 01:47:38 UTC) #5
adg
LGTM
13 years, 1 month ago (2012-03-13 01:57:30 UTC) #6
adg
13 years, 1 month ago (2012-03-13 01:57:53 UTC) #7
*** Submitted as http://code.google.com/p/go/source/detail?r=cbd84deea923 ***

godoc: added alt and title attributes to the "pop out" button

R=adg
CC=golang-dev
http://codereview.appspot.com/5777071

Committer: Andrew Gerrand <adg@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b