Issue 5777066: code review 5777066: codereview: fix for Mercurial 2.1

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5777066: code review 5777066: codereview: fix for Mercurial 2.1 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 1 month ago by rsc

Modified:
13 years, 1 month ago

Reviewers:

CC:
golang-dev, bradfitz

Visibility:
Public.

Description

codereview: fix for Mercurial 2.1 Mercurial: the Python of version control systems. Python: the Mercurial of programming languages.

Patch Set 2 : diff -r 6390db25254b https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 6390db25254b https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r 924ccf7d2edd https://go.googlecode.com/hg/ #

Created: 13 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -0 lines)			Patch
	M	lib/codereview/codereview.py	View	1 2 3	13 chunks	+33 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 1 month ago (2012-03-12 18:21:58 UTC) #1

bradfitz

LGTM http://codereview.appspot.com/5777066/diff/5001/lib/codereview/codereview.py File lib/codereview/codereview.py (right): http://codereview.appspot.com/5777066/diff/5001/lib/codereview/codereview.py#newcode1255 lib/codereview/codereview.py:1255: # Fight one nightmare with another: Python decorators. ...

13 years, 1 month ago (2012-03-12 18:33:02 UTC) #2

rsc

13 years, 1 month ago (2012-03-12 18:39:47 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=1c40c7aee4d6 ***

codereview: fix for Mercurial 2.1

Mercurial: the Python of version control systems.
Python: the Mercurial of programming languages.

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/5777066

Expand All Messages | Collapse All Messages