code review 5777062: cmd/api: set compiler for all build contexts.

cmd/api: set compiler for all build contexts.

The generated syscall files for Windows are still breaking "go tool api"
(unknown function []byte); I'll look at fixing that separately.

Fixes issue 3285.

[dsymonds, 2012-03-11 23:45:03]

Hello bradfitz (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2012-03-12 00:22:42]

LGTM

Aside: I wonder when it broke for windows. Maybe all.bash should run this.
That was the whole point, afterall.
On Mar 11, 2012 4:45 PM, <dsymonds@golang.org> wrote:

> Reviewers: bradfitz,
>
> Message:
> Hello bradfitz (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> cmd/api: set compiler for all build contexts.
>
> The generated syscall files for Windows are still breaking "go tool api"
> (unknown function []byte); I'll look at fixing that separately.
>
> Fixes issue 3285.
>
> Please review this at
http://codereview.appspot.com/**5777062/<http://codereview.appspot.com/5777062/>
>
> Affected files:
>  M src/cmd/api/goapi.go
>
>
> Index: src/cmd/api/goapi.go
> ==============================**==============================**=======
> --- a/src/cmd/api/goapi.go
> +++ b/src/cmd/api/goapi.go
> @@ -52,6 +52,12 @@
>        {GOOS: "windows", GOARCH: "386"},
>  }
>
> +func init() {
> +       for _, c := range contexts {
> +               c.Compiler = build.Default.Compiler
> +       }
> +}
> +
>  func contextName(c *build.Context) string {
>        s := c.GOOS + "-" + c.GOARCH
>        if c.CgoEnabled {
>
>
>

[dsymonds, 2012-03-12 00:25:18]

On Mon, Mar 12, 2012 at 11:22 AM, Brad Fitzpatrick <bradfitz@golang.org> wrote:

> Aside: I wonder when it broke for windows. Maybe all.bash should run this.
That was the whole point, afterall.

I believe the plan was to hook this up to all.bash *after* the APIs
were frozen, which I guess they are now. Not a bad idea.

[dsymonds, 2012-03-12 00:25:46]

*** Submitted as http://code.google.com/p/go/source/detail?r=7f79a9a92e7b ***

cmd/api: set compiler for all build contexts.

The generated syscall files for Windows are still breaking "go tool api"
(unknown function []byte); I'll look at fixing that separately.

Fixes issue 3285.

R=bradfitz
CC=golang-dev
http://codereview.appspot.com/5777062