Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(23)

Issue 5771043: code review 5771043: test: fix testlib to not pass an empty argument to 6g (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 2 months ago by iant
Modified:
13 years, 2 months ago
Reviewers:
CC:
golang-dev, gri, rsc
Visibility:
Public.

Description

test: fix testlib to not pass an empty argument to 6g This change is necessary to make the run shell script work again, but it is not sufficient as bug424.go's execution line does not name the package that it imports.

Patch Set 1 #

Patch Set 2 : diff -r 7f80efcdc862 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M test/testlib View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
iant
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 2 months ago (2012-03-07 16:51:13 UTC) #1
gri
LGTM On Wed, Mar 7, 2012 at 8:51 AM, <iant@golang.org> wrote: > Reviewers: golang-dev_googlegroups.com, > ...
13 years, 2 months ago (2012-03-07 16:53:34 UTC) #2
rsc
Oops, sorry.
13 years, 2 months ago (2012-03-07 16:55:15 UTC) #3
iant
13 years, 2 months ago (2012-03-07 19:17:00 UTC) #4
*** Submitted as http://code.google.com/p/go/source/detail?r=6fc5d3589066 ***

test: fix testlib to not pass an empty argument to 6g

This change is necessary to make the run shell script work
again, but it is not sufficient as bug424.go's execution line
does not name the package that it imports.

R=golang-dev, gri, rsc
CC=golang-dev
http://codereview.appspot.com/5771043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b