Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(231)

Issue 5758063: code review 5758063: misc/cgo/test: fix build (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 2 months ago by rsc
Modified:
13 years, 2 months ago
Reviewers:
r
CC:
golang-dev
Visibility:
Public.

Description

misc/cgo/test: fix build The last CL forgot the all-important 'backdoor' package. Cgo-using packages compile .c files with gcc, but we want to compile this one with 6c, so put it in a non-cgo package.

Patch Set 1 #

Patch Set 2 : diff -r ddf651b0d7fa https://code.google.com/p/go/ #

Patch Set 3 : diff -r ddf651b0d7fa https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -21 lines) Patch
A misc/cgo/test/backdoor/backdoor.go View 1 1 chunk +7 lines, -0 lines 0 comments Download
A misc/cgo/test/backdoor/runtime.c View 1 2 1 chunk +23 lines, -0 lines 0 comments Download
R misc/cgo/test/runtime.c View 1 2 1 chunk +0 lines, -21 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello golang-dev (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
13 years, 2 months ago (2012-03-07 04:38:52 UTC) #1
rsc
*** Submitted as fdb871a77eef *** misc/cgo/test: fix build The last CL forgot the all-important 'backdoor' ...
13 years, 2 months ago (2012-03-07 04:38:56 UTC) #2
r
13 years, 2 months ago (2012-03-07 04:39:58 UTC) #3
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b