code review 5757057: go/build: delete Makefile

go/build: delete Makefile
We can write syslist.go by hand.

[r, 2012-03-07 02:59:28]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[bradfitz, 2012-03-07 03:02:18]

Remove it from .hgignore too.

On Tue, Mar 6, 2012 at 6:59 PM, <r@golang.org> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> go/build: delete Makefile
> We can write syslist.go by hand.
>
> Please review this at
http://codereview.appspot.com/**5757057/<http://codereview.appspot.com/5757057/>
>
> Affected files:
>  R src/pkg/go/build/Makefile
>  M src/pkg/go/build/syslist.go
>
>
> Index: src/pkg/go/build/Makefile
> ==============================**==============================**=======
> deleted file mode 100644
> --- a/src/pkg/go/build/Makefile
> +++ /dev/null
> @@ -1,11 +0,0 @@
> -# Copyright 2009 The Go Authors. All rights reserved.
> -# Use of this source code is governed by a BSD-style
> -# license that can be found in the LICENSE file.
> -
> -syslist.go: ../../../Make.inc Makefile
> -       echo '// Generated automatically by make.' >$@
> -       echo >>$@
> -       echo 'package build' >>$@
> -       echo >>$@
> -       echo 'const goosList = "$(GOOS_LIST)"' >>$@
> -       echo 'const goarchList = "$(GOARCH_LIST)"' >>$@
> Index: src/pkg/go/build/syslist.go
> ==============================**==============================**=======
> --- a/src/pkg/go/build/syslist.go
> +++ b/src/pkg/go/build/syslist.go
> @@ -1,4 +1,6 @@
> -// Generated automatically by make.
> +// Copyright 2011 The Go Authors.  All rights reserved.
> +// Use of this source code is governed by a BSD-style
> +// license that can be found in the LICENSE file.
>
>  package build
>
>
>
>

[bradfitz, 2012-03-07 03:09:59]

LGTM

On Tue, Mar 6, 2012 at 6:59 PM, <r@golang.org> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> go/build: delete Makefile
> We can write syslist.go by hand.
>
> Please review this at
http://codereview.appspot.com/**5757057/<http://codereview.appspot.com/5757057/>
>
> Affected files:
>  R src/pkg/go/build/Makefile
>  M src/pkg/go/build/syslist.go
>
>
> Index: src/pkg/go/build/Makefile
> ==============================**==============================**=======
> deleted file mode 100644
> --- a/src/pkg/go/build/Makefile
> +++ /dev/null
> @@ -1,11 +0,0 @@
> -# Copyright 2009 The Go Authors. All rights reserved.
> -# Use of this source code is governed by a BSD-style
> -# license that can be found in the LICENSE file.
> -
> -syslist.go: ../../../Make.inc Makefile
> -       echo '// Generated automatically by make.' >$@
> -       echo >>$@
> -       echo 'package build' >>$@
> -       echo >>$@
> -       echo 'const goosList = "$(GOOS_LIST)"' >>$@
> -       echo 'const goarchList = "$(GOARCH_LIST)"' >>$@
> Index: src/pkg/go/build/syslist.go
> ==============================**==============================**=======
> --- a/src/pkg/go/build/syslist.go
> +++ b/src/pkg/go/build/syslist.go
> @@ -1,4 +1,6 @@
> -// Generated automatically by make.
> +// Copyright 2011 The Go Authors.  All rights reserved.
> +// Use of this source code is governed by a BSD-style
> +// license that can be found in the LICENSE file.
>
>  package build
>
>
>
>

[r, 2012-03-07 03:10:53]

*** Submitted as http://code.google.com/p/go/source/detail?r=99a66fff2af2 ***

go/build: delete Makefile
We can write syslist.go by hand.

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/5757057