Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1187)

Issue 5757053: Change skia_target_arch != arm to skia_target_arch == x86 in gyp files (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 2 months ago by bsalomon
Modified:
12 years, 2 months ago
Reviewers:
epoger, DerekS, TomH
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

BUG= http://code.google.com/p/skia/issues/detail?id=478

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M gyp/common_variables.gypi View 1 chunk +1 line, -1 line 0 comments Download
M gyp/opts.gyp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7
bsalomon
This is an improvement but still leaves a lot to be desired: 1) It'd be ...
12 years, 2 months ago (2012-03-06 20:26:25 UTC) #1
bsalomon
12 years, 2 months ago (2012-03-06 20:27:01 UTC) #2
TomH
<shrug> LGTM, but I don't know enough to evaluate it. epoger@?
12 years, 2 months ago (2012-03-06 20:28:19 UTC) #3
DerekS
On 2012/03/06 20:28:19, TomH wrote: > <shrug> LGTM, but I don't know enough to evaluate ...
12 years, 2 months ago (2012-03-06 20:29:16 UTC) #4
bsalomon
Adding epoger. The motivation is to stop assuming !arm == x86.
12 years, 2 months ago (2012-03-06 20:29:22 UTC) #5
epoger
LGTM I agree that this is a step in the right direction. Please associate this ...
12 years, 2 months ago (2012-03-06 20:36:37 UTC) #6
bsalomon
12 years, 2 months ago (2012-03-06 21:43:39 UTC) #7
Closed with r3322
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b