This is an improvement but still leaves a lot to be desired: 1) It'd be ...
12 years, 9 months ago
(2012-03-06 20:26:25 UTC)
#1
This is an improvement but still leaves a lot to be desired:
1) It'd be better for the default to infer that the target arch matches the
machine performing the build rather than x86.
2) When the underlying build system supports a flag to cross compile we should
use skia_target_arch to set that flag.
3) There is no distinction between x86 and x86-64.
On 2012/03/06 20:28:19, TomH wrote: > <shrug> LGTM, but I don't know enough to evaluate ...
12 years, 9 months ago
(2012-03-06 20:29:16 UTC)
#4
On 2012/03/06 20:28:19, TomH wrote:
> <shrug> LGTM, but I don't know enough to evaluate it. epoger@?
LGTM. I agree it can be improved beyond this but this is much better than what
we have now.
LGTM I agree that this is a step in the right direction. Please associate this ...
12 years, 9 months ago
(2012-03-06 20:36:37 UTC)
#6
LGTM
I agree that this is a step in the right direction.
Please associate this change with
http://code.google.com/p/skia/issues/detail?id=478 ('gyp cleanup: list valid
skia_target_arch values, and set to 'x86' by default'), and weigh in there with
thoughts on other areas where we need to clean this up.
For instance, do we still need to check skia_target_arch before setting the
-msse2 compiler flag?
Issue 5757053: Change skia_target_arch != arm to skia_target_arch == x86 in gyp files
(Closed)
Created 12 years, 9 months ago by bsalomon
Modified 12 years, 9 months ago
Reviewers: DerekS, TomH, epoger
Base URL: http://skia.googlecode.com/svn/trunk/
Comments: 0