Issue 5756074: code review 5756074: cmd/gc: do not confuse unexported methods of same name

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5756074: code review 5756074: cmd/gc: do not confuse unexported methods of same name (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 2 months ago by rsc

Modified:
13 years, 2 months ago

Reviewers:
ken3

CC:
ken2, golang-dev

Visibility:
Public.

cmd/gc: do not confuse unexported methods of same name Fixes issue 3146.

Created: 13 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -14 lines)			Patch
M	src/cmd/gc/dcl.c	View	1 2	1 chunk	+11 lines, -4 lines	0 comments	Download
R	test/bugs/424.go	View	1	1 chunk	+0 lines, -9 lines	0 comments	Download
M	test/fixedbugs/bug424.go	View	1	3 chunks	+16 lines, -2 lines	0 comments	Download
M	test/fixedbugs/bug424.dir/lib.go	View	1	0 chunks	+-1 lines, --1 lines	0 comments	Download

Total messages: 3

rsc

Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

13 years, 2 months ago (2012-03-07 06:55:14 UTC) #1

rsc

*** Submitted as 4346881f5c9d *** cmd/gc: do not confuse unexported methods of same name Fixes ...

13 years, 2 months ago (2012-03-07 06:55:20 UTC) #2

lgtm