Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(459)

Issue 5756070: code review 5756070: go_faq: a simple binary is a little smaller now (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 2 months ago by r
Modified:
13 years, 2 months ago
Reviewers:
CC:
golang-dev, rsc
Visibility:
Public.

Description

go_faq: a simple binary is a little smaller now About 10% for hello, world. Maybe more reductions will come. Also clarify that we're comparing printf against Printf (gcc can optimize aggressively, making this a different sort of comparison).

Patch Set 1 #

Patch Set 2 : diff -r 4f17a4370f1c https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M doc/go_faq.html View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 3
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
13 years, 2 months ago (2012-03-07 04:23:46 UTC) #1
rsc
LGTM
13 years, 2 months ago (2012-03-07 04:28:18 UTC) #2
r
13 years, 2 months ago (2012-03-07 04:29:31 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=e490e0c102e8 ***

go_faq: a simple binary is a little smaller now
About 10% for hello, world.
Maybe more reductions will come.
Also clarify that we're comparing printf against Printf
(gcc can optimize aggressively, making this a different
sort of comparison).

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/5756070
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b