Issue 5756067: code review 5756067: all: remove some references to Make.inc etc.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5756067: code review 5756067: all: remove some references to Make.inc etc. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 2 months ago by r

Modified:
13 years, 2 months ago

Reviewers:

CC:
golang-dev, bradfitz

Visibility:
Public.

Description

all: remove some references to Make.inc etc. There are a few more but these are the easiest ones.

Patch Set 2 : diff -r 061659a08477 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 6547d4f46a50 https://code.google.com/p/go/ #

Created: 13 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -28 lines)			Patch
M	src/cmd/cgo/doc.go	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/cmd/cgo/main.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/lib9/utf/Makefile	View		2 chunks	+6 lines, -8 lines	0 comments	Download
M	test/bench/garbage/Makefile	View		1 chunk	+6 lines, -11 lines	0 comments	Download
M	test/bench/go1/Makefile	View		1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

13 years, 2 months ago (2012-03-07 02:19:36 UTC) #1

bradfitz

http://codereview.appspot.com/5756067/diff/1/src/cmd/cgo/doc.go File src/cmd/cgo/doc.go (right): http://codereview.appspot.com/5756067/diff/1/src/cmd/cgo/doc.go#newcode114 src/cmd/cgo/doc.go:114: The standard package construction rules in of the go ...

13 years, 2 months ago (2012-03-07 02:24:43 UTC) #2

Hello golang-dev@googlegroups.com, bradfitz@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

13 years, 2 months ago (2012-03-07 02:47:48 UTC) #3

bradfitz

LGTM On Mar 6, 2012 6:47 PM, <r@golang.org> wrote: > Hello golang-dev@googlegroups.com, bradfitz@golang.org (cc: > ...

13 years, 2 months ago (2012-03-07 02:49:11 UTC) #4

13 years, 2 months ago (2012-03-07 02:51:54 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=694a6eeb3443 ***

all: remove some references to Make.inc etc.
There are a few more but these are the easiest ones.

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/5756067

Expand All Messages | Collapse All Messages