code review 5756045: go/parser: better error sync. if commas are missing

go/parser: better error sync. if commas are missing

[gri, 2012-03-06 00:43:25]

Hello rsc@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[rsc, 2012-03-06 02:25:37]

LGTM

works great, thanks very much

[bradfitz, 2012-03-06 02:29:36]

Where will this surface to users? gofmt? Won't most users hit problems in
gc first?

On Mon, Mar 5, 2012 at 6:25 PM, Russ Cox <rsc@golang.org> wrote:

> LGTM
>
> works great, thanks very much
>

[rsc, 2012-03-06 02:34:53]

On Mon, Mar 5, 2012 at 21:29, Brad Fitzpatrick <bradfitz@golang.org> wrote:
> Where will this surface to users? gofmt? Won't most users hit problems in gc
> first?

This turned many screens of syntax errors into 1 line for me when I
delete a single comma from my go/build/deps_test.go file.
I hit it in gofmt, but go test reads _test.go files with go/parser
before gc gets them too.  I've been reporting these as I find them.
At some point - after Go 1, and once go/parser's errors are uniformly
as good or better than gc's - I think we'll want to run a quick syntax
check on the Go programs before invoking either compiler.

Russ

[bradfitz, 2012-03-06 02:39:35]

On Mon, Mar 5, 2012 at 6:34 PM, Russ Cox <rsc@golang.org> wrote:

> On Mon, Mar 5, 2012 at 21:29, Brad Fitzpatrick <bradfitz@golang.org>
> wrote:
> > Where will this surface to users? gofmt? Won't most users hit problems
> in gc
> > first?
>
> This turned many screens of syntax errors into 1 line for me when I
> delete a single comma from my go/build/deps_test.go file.
> I hit it in gofmt, but go test reads _test.go files with go/parser
> before gc gets them too.


ah!


> I've been reporting these as I find them.
> At some point - after Go 1, and once go/parser's errors are uniformly
> as good or better than gc's - I think we'll want to run a quick syntax
> check on the Go programs before invoking either compiler.


Cool.

[gri, 2012-03-06 19:05:20]

*** Submitted as http://code.google.com/p/go/source/detail?r=dfb43cb84d5f ***

go/parser: better error sync. if commas are missing

R=rsc, bradfitz
CC=golang-dev
http://codereview.appspot.com/5756045