Issue 5755054: code review 5755054: go.crypto/ssh: add support for diffie-hellman-group1-sha1.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5755054: code review 5755054: go.crypto/ssh: add support for diffie-hellman-group1-sha1. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by kardia

Modified:
12 years ago

Reviewers:

CC:
golang-dev, agl1

Visibility:
Public.

Description

go.crypto/ssh: add support for diffie-hellman-group1-sha1. Fixes issue 2903.

Patch Set 1 #

Patch Set 2 : diff -r b87c16c531f3 http://code.google.com/p/go.crypto #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -1 line)			Patch
M	ssh/client.go	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	ssh/common.go	View	1	3 chunks	+17 lines, -1 line	0 comments	Download
M	ssh/server.go	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

kardia

Hello golang-dev@googlegroups.com (cc: agl@golang.org, golang-dev@googlegroups.com), I'd like you to review this change to http://code.google.com/p/go.crypto

12 years, 1 month ago (2012-03-06 15:40:47 UTC) #1

agl1

*** Submitted as http://code.google.com/p/go/source/detail?r=676f4a693124&repo=crypto *** go.crypto/ssh: add support for diffie-hellman-group1-sha1. Fixes issue 2903. R=golang-dev CC=agl, ...

12 years, 1 month ago (2012-03-06 16:26:04 UTC) #2

*** Abandoned ***

Expand All Messages | Collapse All Messages