Issue 5755053: code review 5755053: doc: remove unsued progs and makehtml script, update pr...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5755053: code review 5755053: doc: remove unsued progs and makehtml script, update pr... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 2 months ago by minux1

Modified:
13 years, 2 months ago

Reviewers:

CC:
golang-dev, adg

Visibility:
Public.

Description

doc: remove unsued progs and makehtml script, update progs/run Due to removal of go_tutorial, unused programs are removed. makehtml is unnecessary (it also gives wrong messages when the destination file doesn't exist) progs/run now compiles all remaining programs under doc/progs. Fixes issue 3076 (again)

Patch Set 1 #

Patch Set 2 : diff -r f6523e003ea9 https://code.google.com/p/go/ #

Patch Set 3 : diff -r f6523e003ea9 https://code.google.com/p/go/ #

Patch Set 4 : diff -r f6523e003ea9 https://code.google.com/p/go/ #

Patch Set 5 : diff -r f6523e003ea9 https://code.google.com/p/go/ #

Created: 13 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -300 lines)			Patch
M	doc/Makefile	View	1	1 chunk	+4 lines, -1 line	0 comments	Download
R	doc/makehtml	View	1	1 chunk	+0 lines, -17 lines	0 comments	Download
R	doc/progs/helloworld.go	View	1	1 chunk	+0 lines, -11 lines	0 comments	Download
R	doc/progs/helloworld3.go	View	1	1 chunk	+0 lines, -21 lines	0 comments	Download
R	doc/progs/print.go	View	1	1 chunk	+0 lines, -23 lines	0 comments	Download
R	doc/progs/print_string.go	View	1	1 chunk	+0 lines, -21 lines	0 comments	Download
M	doc/progs/run	View	1 2 3	2 chunks	+9 lines, -2 lines	0 comments	Download
R	doc/progs/server.go	View	1	1 chunk	+0 lines, -51 lines	0 comments	Download
R	doc/progs/server1.go	View	1	1 chunk	+0 lines, -56 lines	0 comments	Download
R	doc/progs/sort.go	View	1	1 chunk	+0 lines, -59 lines	0 comments	Download
R	doc/progs/strings.go	View	1	1 chunk	+0 lines, -17 lines	0 comments	Download
R	doc/progs/sum.go	View	1	1 chunk	+0 lines, -21 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

minux1

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

13 years, 2 months ago (2012-03-06 15:55:09 UTC) #1

adg

13 years, 2 months ago (2012-03-06 21:05:12 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=7618566d7ced ***

doc: remove unsued progs and makehtml script, update progs/run
        Due to removal of go_tutorial, unused programs are removed.
        makehtml is unnecessary (it also gives wrong messages when
        the destination file doesn't exist)
        progs/run now compiles all remaining programs under doc/progs.
        Fixes issue 3076 (again)

R=golang-dev, adg
CC=golang-dev
http://codereview.appspot.com/5755053

Committer: Andrew Gerrand <adg@golang.org>

Expand All Messages | Collapse All Messages