Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(253)

Issue 5754102: [ASan/Win] Eliminate a couple of FIXMEs, add NORETURN to CheckFailed/UNIMPLEMENTED (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years ago by timurrrr_at_google_com
Modified:
12 years ago
Reviewers:
glider
CC:
llvm-commits_cs.uiuc.edu
Visibility:
Public.

Description

Eliminate a couple of FIXMEs, add NORETURN to CheckFailed/UNIMPLEMENTED Committed as http://llvm.org/viewvc/llvm-project?view=rev&revision=152628

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -7 lines) Patch
M lib/asan/asan_internal.h View 3 chunks +4 lines, -1 line 0 comments Download
M lib/asan/asan_win.cc View 1 4 chunks +12 lines, -6 lines 0 comments Download

Messages

Total messages: 3
timurrrr_at_google_com
Hi Alexander, Can you please review this patch? Thanks, Timur
12 years ago (2012-03-13 14:01:19 UTC) #1
glider
LGTM
12 years ago (2012-03-13 16:12:14 UTC) #2
timurrrr_at_google_com
12 years ago (2012-03-13 16:16:59 UTC) #3
On 2012/03/13 16:12:14, glider wrote:
> LGTM

r152628, thanks!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b