Issue 5754102: [ASan/Win] Eliminate a couple of FIXMEs, add NORETURN to CheckFailed/UNIMPLEMENTED

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5754102: [ASan/Win] Eliminate a couple of FIXMEs, add NORETURN to CheckFailed/UNIMPLEMENTED (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 8 months ago by timurrrr_at_google_com

Modified:
12 years, 8 months ago

Reviewers:
glider

CC:
llvm-commits_cs.uiuc.edu

Visibility:
Public.

Eliminate a couple of FIXMEs, add NORETURN to CheckFailed/UNIMPLEMENTED Committed as http://llvm.org/viewvc/llvm-project?view=rev&revision=152628

Created: 12 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -7 lines)			Patch
	M	lib/asan/asan_internal.h	View		3 chunks	+4 lines, -1 line	0 comments	Download
	M	lib/asan/asan_win.cc	View	1	4 chunks	+12 lines, -6 lines	0 comments	Download

Total messages: 3

timurrrr_at_google_com

Hi Alexander, Can you please review this patch? Thanks, Timur

12 years, 8 months ago (2012-03-13 14:01:19 UTC) #1

timurrrr_at_google_com

12 years, 8 months ago (2012-03-13 16:16:59 UTC) #3

On 2012/03/13 16:12:14, glider wrote:
> LGTM

r152628, thanks!