Issue 5754091: code review 5754091: runtime: fix windows/amd64

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5754091: code review 5754091: runtime: fix windows/amd64 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 1 month ago by rsc

Modified:
13 years, 1 month ago

Reviewers:
brainman, hector, bradfitz

CC:
golang-dev

Visibility:
Public.

Patch Set 2 : diff -r 58e7a6ccfce2 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 58e7a6ccfce2 https://go.googlecode.com/hg/ #

Total comments: 1

Created: 13 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -2 lines)			Patch
	M	src/pkg/runtime/sys_windows_amd64.s	View	1	3 chunks	+9 lines, -2 lines	1 comment	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rsc

Hello bradfitz (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 1 month ago (2012-03-12 20:48:13 UTC) #1

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=52caddd5d95a *** runtime: fix windows/amd64 Maybe. TBR=bradfitz CC=golang-dev http://codereview.appspot.com/5754091

13 years, 1 month ago (2012-03-12 20:48:19 UTC) #2

bradfitz

LGTM not really, still failing, but differently now: ok html 0.028s exit status -1073741819 FAIL ...

13 years, 1 month ago (2012-03-12 22:21:02 UTC) #3

hector

http://codereview.appspot.com/5754091/diff/3/src/pkg/runtime/sys_windows_amd64.s File src/pkg/runtime/sys_windows_amd64.s (right): http://codereview.appspot.com/5754091/diff/3/src/pkg/runtime/sys_windows_amd64.s#newcode140 src/pkg/runtime/sys_windows_amd64.s:140: MOVQ m(BX), AX Will changing this to m(CX) fix ...

13 years, 1 month ago (2012-03-12 23:07:59 UTC) #4

brainman

13 years, 1 month ago (2012-03-12 23:19:57 UTC) #5

On 2012/03/12 23:07:59, hector wrote:
> ...
> Will changing this to m(CX) fix it?

It does. Exception handler is broken at this moment, and it is calling default
(Windows one). I will check some more and send fix. Unless someone else will
beat me to it.

Alex

Expand All Messages | Collapse All Messages