code review 5754088: cmd/go: respect $GOBIN always

cmd/go: respect $GOBIN always

Before, we only consulted $GOBIN for source code
found in $GOROOT, but that's confusing to explain
and less useful.  The new behavior lets users set
GOBIN=$HOME/bin and have all go-compiled binaries
installed there.

Fixes issue 3269.

[rsc, 2012-03-12 19:07:34]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2012-03-12 19:59:37]

The issue refers to needing to update the documentation.

Do that in this CL?


On Mon, Mar 12, 2012 at 12:07 PM, <rsc@golang.org> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> cmd/go: respect $GOBIN always
>
> Before, we only consulted $GOBIN for source code
> found in $GOROOT, but that's confusing to explain
> and less useful.  The new behavior lets users set
> GOBIN=$HOME/bin and have all go-compiled binaries
> installed there.
>
> Fixes issue 3269.
>
> Please review this at
http://codereview.appspot.com/**5754088/<http://codereview.appspot.com/5754088/>
>
> Affected files:
>  src/cmd/go/build.go
>  src/cmd/go/pkg.go
>
>
> Index: src/cmd/go/build.go
> ==============================**==============================**=======
> --- a/src/cmd/go/build.go
> +++ b/src/cmd/go/build.go
> @@ -302,20 +302,13 @@
>  )
>
>  var (
> +       gobin        = os.Getenv("GOBIN")
>        goroot       = filepath.Clean(runtime.GOROOT(**))
> -       gobin        = defaultGobin()
>        gorootSrcPkg = filepath.Join(goroot, "src/pkg")
>        gorootPkg    = filepath.Join(goroot, "pkg")
>        gorootSrc    = filepath.Join(goroot, "src")
>  )
>
> -func defaultGobin() string {
> -       if s := os.Getenv("GOBIN"); s != "" {
> -               return s
> -       }
> -       return filepath.Join(goroot, "bin")
> -}
> -
>  func (b *builder) init() {
>        var err error
>        b.print = fmt.Print
> Index: src/cmd/go/pkg.go
> ==============================**==============================**=======
> --- a/src/cmd/go/pkg.go
> +++ b/src/cmd/go/pkg.go
> @@ -276,6 +276,9 @@
>  // load populates p using information from bp, err, which should
>  // be the result of calling build.Context.Import.
>  func (p *Package) load(stk *importStack, bp *build.Package, err error)
> *Package {
> +       if gobin != "" {
> +               bp.BinDir = gobin
> +       }
>        p.copyBuild(bp)
>
>        // The localPrefix is the path we interpret ./ imports relative to.
> @@ -538,7 +541,6 @@
>                bp, err := build.ImportDir(filepath.Join(**gorootSrc,
> arg), 0)
>                bp.ImportPath = arg
>                bp.Goroot = true
> -               bp.BinDir = gobin
>                bp.Root = goroot
>                bp.SrcRoot = gorootSrc
>                p := new(Package)
>
>
>

[rsc, 2012-03-12 20:42:25]

PTAL

[bradfitz, 2012-03-12 20:45:46]

LGTM

On Mon, Mar 12, 2012 at 1:42 PM, Russ Cox <rsc@golang.org> wrote:

> PTAL
>

[rsc, 2012-03-12 20:49:15]

*** Submitted as http://code.google.com/p/go/source/detail?r=cae9a7c0db06 ***

cmd/go: respect $GOBIN always

Before, we only consulted $GOBIN for source code
found in $GOROOT, but that's confusing to explain
and less useful.  The new behavior lets users set
GOBIN=$HOME/bin and have all go-compiled binaries
installed there.

Fixes issue 3269.

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/5754088