Issue 5754082: code review 5754082: cmd/api: work on Windows again, and make gccgo files wo...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5754082: code review 5754082: cmd/api: work on Windows again, and make gccgo files wo... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 1 month ago by bradfitz

Modified:
13 years, 1 month ago

Reviewers:

CC:
golang-dev, dsymonds

Visibility:
Public.

Description

cmd/api: work on Windows again, and make gccgo files work a bit more handle string and []byte conversions.

Patch Set 1 #

Patch Set 2 : diff -r 7f79a9a92e7b https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 7f79a9a92e7b https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 7f79a9a92e7b https://go.googlecode.com/hg/ #

Created: 13 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -2 lines)			Patch
M	src/cmd/api/goapi.go	View	1 2 3	1 chunk	+8 lines, -1 line	0 comments	Download
M	src/cmd/api/testdata/src/pkg/p1/golden.txt	View	1 2 3	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/cmd/api/testdata/src/pkg/p1/p1.go	View	1 2 3	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 1 month ago (2012-03-12 00:41:31 UTC) #1

bradfitz

*** Submitted as http://code.google.com/p/go/source/detail?r=e07bc909079c *** cmd/api: work on Windows again, and make gccgo files work ...

13 years, 1 month ago (2012-03-12 00:55:18 UTC) #3

bradfitz

13 years, 1 month ago (2012-03-12 00:56:08 UTC) #4

(FYI: added unreviewed test before submitting...)

On Sun, Mar 11, 2012 at 5:55 PM, <bradfitz@golang.org> wrote:

> *** Submitted as
>
http://code.google.com/p/go/**source/detail?r=e07bc909079c<http://code.google...
>
>
> cmd/api: work on Windows again, and make gccgo files work a bit more
>
> handle string and []byte conversions.
>
> R=golang-dev, dsymonds
> CC=golang-dev
> http://codereview.appspot.com/**5754082<http://codereview.appspot.com/5754082>
>
>
>
http://codereview.appspot.com/**5754082/<http://codereview.appspot.com/5754082/>
>

Expand All Messages | Collapse All Messages