Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(444)

Issue 5754067: [google] save -std to lipo profile

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years ago by xur
Modified:
12 years ago
Reviewers:
davidxl
CC:
gcc-patches_gcc.gnu.org
Base URL:
svn+ssh://gcc.gnu.org/svn/gcc/branches/google/main/gcc/
Visibility:
Public.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M opts-global.c View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 2
xur
Hi, This patch is for google branches only. It saves -std=* option to lipo profile ...
12 years ago (2012-03-09 18:59:25 UTC) #1
davidxl
12 years ago (2012-03-09 19:39:03 UTC) #2
ok for google branches.

David

On Fri, Mar 9, 2012 at 10:59 AM, Rong Xu <xur@google.com> wrote:
> Hi,
>
> This patch is for google branches only.
>
> It saves -std=* option to lipo profile so that non-c99 primary module
> can include c99 auxiliay modules with restrict keyword.
>
> Tested with bootstrap and google internal benchmarks.
>
> -Rong
>
> 2012-03-09   Rong Xu  <xur@google.com>
>
>        * opts-global.c (lipo_save_cl_args): save -std option.
>        Google ref b/6117980.
>
> Index: opts-global.c
> ===================================================================
> --- opts-global.c       (revision 185148)
> +++ opts-global.c       (working copy)
> @@ -210,10 +210,12 @@
>      (3) -W...
>      (4) -O...
>      (5) --param...
> +     (6) -std=... (-std=c99 for restrict keyword)
>   */
>   if (opt[0] == '-'
>       && (opt[1] == 'f' || opt[1] == 'm' || opt[1] == 'W' || opt[1] == 'O'
> -         || (strstr (opt, "--param") == opt))
> +         || (strstr (opt, "--param") == opt)
> +         || (strstr (opt, "-std=")))
>       && !strstr(opt, "-frandom-seed")
>       && !strstr(opt, "-fripa-disallow-opt-mismatch")
>       && !strstr(opt, "-Wripa-opt-mismatch"))
>
> --
> This patch is available for review at http://codereview.appspot.com/5754067
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b